Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 11941029: Merge 176755 (Closed)

Created:
7 years, 11 months ago by Raghu Simha
Modified:
7 years, 11 months ago
Reviewers:
Raghu Simha
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 176755 > [sync] [chromeos] Fix setup flow when sync data is cleared via dashboard and sync is set up again > > On Chrome OS, when a user clears their sync data via the dashboard, logs > out, logs in again, and attempts to set up sync once more, the setup > flow ends up getting stuck after the backend is initialized, because > SigninTracker does not respond to the OnStateChanged call from > ProfileSyncService::OnBackendInitialized. > > This regression can be traced back to r171190, where SigninTracker was > no longer initialized with the SigninTracker::SERVICES_INITIALIZING > state in SyncSetupHandler::DisplayConfigureSync. This was causing > SigninTracker to drop the OnStateChanged call from ProfileSyncService > in the scenario where the user attempted to set up sync while already > signed in to the Chrome OS device after clearing sync data via the > dashboard. > > This patch restores the initial SigninTracker state in > SyncSetupHandler::DisplayConfigureSync. It also fixes the > unittests that were previously failing in the original CL. > > BUG=167090, 168064, 168875, 81265 > TEST=On ChromeOS, clear the dashboard, log out, log in, and set up sync. > > Review URL: https://codereview.chromium.org/11824021 TBR=rsimha@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M chrome/browser/ui/webui/sync_setup_handler.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 2 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Raghu Simha
7 years, 11 months ago (2013-01-19 02:24:00 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698