Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: src/hydrogen.cc

Issue 11941013: Don't insert HDummyUses for control instructions (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index 3423d4b288a89c170abd41b4980188fcac2b24fc..a4578ee3dfa5324e94cdd9ae32c2b08ffd9b7852 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -1303,6 +1303,12 @@ void HGraph::NullifyUnreachableInstructions() {
}
continue;
}
+ if (operand->IsControlInstruction()) {
+ // Inserting a dummy use for a value that's not defined anywhere
+ // will fail. Some instructions define fake inputs on such
+ // values as control flow dependencies.
+ continue;
+ }
HDummyUse* dummy = new(zone()) HDummyUse(operand);
dummy->InsertBefore(instr);
last_dummy = dummy;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698