Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(46)

Issue 1194073002: Expanded code in CompareCSSValuePtr to be more readable (Closed)

Created:
4 years, 10 months ago by sashab
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, dominickn, dstockwell, Mike Lawther (Google), rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expanded code in CompareCSSValuePtr to be more readable Expanded the ternary operator in CSSValuePtr to a set of if-statements that are much more readable. This code was previously difficult to understand and this change should not noticeably affect performance (this code is not part of a performance-critical path). For more info, see this doc: https://docs.google.com/document/d/1srJG5_Obcmty8NlsTNMJiYhVZlMdmzASWJHPnIQNB0I/edit Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197496

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M Source/core/css/CSSValue.h View 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sashab
4 years, 10 months ago (2015-06-19 18:43:30 UTC) #2
esprehn
lgtm, down with the ternaries!
4 years, 10 months ago (2015-06-19 18:46:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194073002/1
4 years, 10 months ago (2015-06-19 18:47:31 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 20:13:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197496

Powered by Google App Engine
This is Rietveld 408576698