grit/node/structure.py - Issue 1194063002: grit: Add fallback_to_default_layout attribute to <output>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/node/structure.py

Issue 1194063002: grit: Add fallback_to_default_layout attribute to <output> (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: for landing Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: grit/node/structure.py

diff --git a/grit/node/structure.py b/grit/node/structure.py

index 7ccd2fbcf6c738cb20916b9bc928c20dd1ed77b3..331a646cb5217dd20a879d83e9c5661c3e9a5369 100644

--- a/grit/node/structure.py

+++ b/grit/node/structure.py

@@ -291,7 +291,10 @@ class StructureNode(base.Node):

(not self.attrs['run_command'] or

not self.RunCommandOnCurrentPlatform())):

if return_if_not_generated:

- return self.ToRealPath(self.GetInputPath())

+ input_path = self.GetInputPath()

+ if input_path is None:

+ return None

+ return self.ToRealPath(input_path)

else:

return None

« no previous file with comments | « grit/node/misc.py ('k') | grit/tool/build.py » ('j') | no next file with comments »