Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Issue 1194053003: Close tray bubble before disabling UI for sign-in. (Closed)

Created:
5 years, 6 months ago by dzhioev (left Google)
Modified:
5 years, 6 months ago
Reviewers:
achuithb
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close tray bubble before disabling UI for sign-in. During Chrome OS sign-in we temperoraly block the UI, to prevent user from interracting with UI elements, particullary with the system tray menu. However, if system tray menu is opened before disabling the UI, it remains opened after. Fixed this by closing the menu together with disabling the UI. BUG=497080 TEST=manually Review URL: https://codereview.chromium.org/1187593006 Cr-Commit-Position: refs/heads/master@{#335133} Committed: https://crrev.com/54491dc0ca9c5edbbc300e0e7cc56ad2beee3fe7 Cr-Commit-Position: refs/heads/master@{#335562}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 1 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
dzhioev (left Google)
Hello, PTAL
5 years, 6 months ago (2015-06-19 23:44:16 UTC) #2
achuithb
https://codereview.chromium.org/1194053003/diff/1/chrome/browser/chromeos/login/ui/webui_login_view.cc File chrome/browser/chromeos/login/ui/webui_login_view.cc (right): https://codereview.chromium.org/1194053003/diff/1/chrome/browser/chromeos/login/ui/webui_login_view.cc#newcode352 chrome/browser/chromeos/login/ui/webui_login_view.cc:352: if (!enabled && tray->HasSystemBubble()) Could you please add a ...
5 years, 6 months ago (2015-06-19 23:52:06 UTC) #3
dzhioev (left Google)
Done.
5 years, 6 months ago (2015-06-20 00:20:33 UTC) #4
achuithb
lgtm
5 years, 6 months ago (2015-06-22 18:53:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194053003/20001
5 years, 6 months ago (2015-06-22 19:10:03 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/30690)
5 years, 6 months ago (2015-06-22 19:52:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194053003/20001
5 years, 6 months ago (2015-06-22 20:22:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-22 21:20:39 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 21:21:31 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54491dc0ca9c5edbbc300e0e7cc56ad2beee3fe7
Cr-Commit-Position: refs/heads/master@{#335562}

Powered by Google App Engine
This is Rietveld 408576698