Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1194053002: Use the same range for upper/lower-armenian as armenian (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use the same range for upper/lower-armenian as armenian According to the specification [1] upper-armenian and lower-armenian support the same range as armenian, so fix effectiveListMarkerType. This ensures the reported ASSERT is not hit, I changed w3-css3-list-styles-fallback-style.html to test this. [1] http://dev.w3.org/csswg/css-counter-styles/#simple-numeric BUG=501733 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M LayoutTests/fast/lists/w3-css3-list-styles-fallback-style.html View 2 chunks +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/lists/w3-css3-list-styles-fallback-style-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutListMarker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
rwlbuis
PTAL
5 years, 6 months ago (2015-06-19 20:44:41 UTC) #2
tkent
lgtm
5 years, 6 months ago (2015-06-22 01:15:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194053002/1
5 years, 6 months ago (2015-06-22 01:16:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59983)
5 years, 6 months ago (2015-06-22 02:39:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194053002/1
5 years, 6 months ago (2015-06-22 03:05:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59989)
5 years, 6 months ago (2015-06-22 04:36:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194053002/1
5 years, 6 months ago (2015-06-22 04:41:47 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 05:47:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197552

Powered by Google App Engine
This is Rietveld 408576698