Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 1194033002: Enable Slimming Paint for all but "bugs" tables layout tests. (Closed)

Created:
4 years, 10 months ago by Stephen Chennney
Modified:
4 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable Slimming Paint for all but "bugs" tables layout tests. R=wangxianzhu,chrishtr,pdr BUG=497950 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197503

Patch Set 1 #

Patch Set 2 : Missing some, now fixed #

Patch Set 3 : All in one #

Patch Set 4 : Expectations now added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+706 lines, -17 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 3 chunks +705 lines, -9 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 2 3 2 chunks +0 lines, -8 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Stephen Chennney
Using trybots to see failures. Not ready for review.
4 years, 10 months ago (2015-06-19 17:11:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194033002/60001
4 years, 10 months ago (2015-06-19 20:55:54 UTC) #3
Stephen Chennney
Ready for review. All the rebaselines are due to one-pixel or one-pixel-wide changes at the ...
4 years, 10 months ago (2015-06-19 20:56:52 UTC) #4
Stephen Chennney
Example changes: https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/67623/layout-test-results/results.html
4 years, 10 months ago (2015-06-19 20:57:32 UTC) #5
Stephen Chennney
I do think I know why this is happening: we're overdrawing corners and Skia's blending ...
4 years, 10 months ago (2015-06-19 20:59:36 UTC) #6
Xianzhu
On 2015/06/19 20:59:36, Stephen Chenney wrote: > I do think I know why this is ...
4 years, 10 months ago (2015-06-19 21:02:36 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-19 22:38:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194033002/60001
4 years, 10 months ago (2015-06-19 22:44:27 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 23:14:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197503

Powered by Google App Engine
This is Rietveld 408576698