Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 119403002: net: add GlobalSign to Twitter CDN pins. (Closed)

Created:
7 years ago by agl
Modified:
6 years, 11 months ago
Reviewers:
palmer
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -6 lines) Patch
M net/http/transport_security_state_static.h View 3 chunks +16 lines, -2 lines 0 comments Download
M net/http/transport_security_state_static.certs View 1 chunk +70 lines, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 2 chunks +5 lines, -3 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
agl
7 years ago (2013-12-19 22:46:44 UTC) #1
palmer
LGTM. Cert fingerprints match the given hashes.
7 years ago (2013-12-19 23:46:33 UTC) #2
palmer
Does this need landing soon?
6 years, 11 months ago (2013-12-31 00:10:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/119403002/1
6 years, 11 months ago (2013-12-31 01:33:52 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=208942
6 years, 11 months ago (2013-12-31 02:18:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/119403002/280001
6 years, 11 months ago (2014-01-06 19:33:38 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242090
6 years, 11 months ago (2014-01-06 23:29:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/119403002/280001
6 years, 11 months ago (2014-01-07 00:28:54 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242344
6 years, 11 months ago (2014-01-07 13:07:27 UTC) #9
agl
6 years, 11 months ago (2014-01-07 16:00:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 manually as r243302 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698