Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1194023004: Let AddDictionaryElement / AddFastElement purely add, move transition heuristics to AddDataElement (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let AddDictionaryElement / AddFastElement purely add, move transition heuristics to AddDataElement BUG=v8:4137 LOG=n Committed: https://crrev.com/210be5215dae17e3070e672ced7f2c58465aab66 Cr-Commit-Position: refs/heads/master@{#29287}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Get rid of some branching #

Patch Set 4 : #

Patch Set 5 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -205 lines) Patch
M src/objects.h View 1 2 3 4 chunks +3 lines, -15 lines 0 comments Download
M src/objects.cc View 1 2 3 9 chunks +162 lines, -190 lines 0 comments Download
M test/mjsunit/arguments.js View 1 2 3 4 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-23 16:06:09 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-24 12:41:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194023004/70001
5 years, 6 months ago (2015-06-25 09:02:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194023004/90001
5 years, 6 months ago (2015-06-25 09:04:49 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 6 months ago (2015-06-25 10:48:55 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 10:49:13 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/210be5215dae17e3070e672ced7f2c58465aab66
Cr-Commit-Position: refs/heads/master@{#29287}

Powered by Google App Engine
This is Rietveld 408576698