Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1194013002: [patch 6 of 6] CrossSiteDocumentClassifier bug fixes. (Closed)

Created:
5 years, 6 months ago by ncarter (slow)
Modified:
5 years, 5 months ago
Reviewers:
dsjang1, alexmos
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[patch 6 of 6] CrossSiteDocumentClassifier bug fixes. Fixes two issues with document sniffing: 1. Correctly classify the HTML DTD (add a test for this) as HTML. 2. Classify XML as XML, not HTML. BUG=369312, 268640 Committed: https://crrev.com/99911aade67e8863efbdb7da0d7e0b08d98825d4 Cr-Commit-Position: refs/heads/master@{#335391}

Patch Set 1 #

Patch Set 2 : Self review fix. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M content/child/site_isolation_stats_gatherer_browsertest.cc View 1 2 chunks +17 lines, -13 lines 0 comments Download
M content/common/cross_site_document_classifier.cc View 4 chunks +4 lines, -5 lines 2 comments Download
A content/test/data/site_isolation/html4_dtd.html View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/site_isolation/html4_dtd.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/site_isolation/html5_dtd.html View 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/site_isolation/html5_dtd.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ncarter (slow)
Alex, please take a look. This fixes the XML bug you figured out, as well ...
5 years, 6 months ago (2015-06-19 16:47:48 UTC) #2
alexmos
LGTM. Thanks for fixing these!
5 years, 6 months ago (2015-06-19 21:55:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194013002/20001
5 years, 6 months ago (2015-06-19 22:51:04 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 23:27:54 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/99911aade67e8863efbdb7da0d7e0b08d98825d4 Cr-Commit-Position: refs/heads/master@{#335391}
5 years, 6 months ago (2015-06-19 23:28:56 UTC) #7
dsjang1
https://codereview.chromium.org/1194013002/diff/20001/content/common/cross_site_document_classifier.cc File content/common/cross_site_document_classifier.cc (left): https://codereview.chromium.org/1194013002/diff/20001/content/common/cross_site_document_classifier.cc#oldcode170 content/common/cross_site_document_classifier.cc:170: }; What was the reason behind removing <?xml from ...
5 years, 5 months ago (2015-07-01 00:34:54 UTC) #9
alexmos
5 years, 5 months ago (2015-07-06 17:03:38 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1194013002/diff/20001/content/common/cross_si...
File content/common/cross_site_document_classifier.cc (left):

https://codereview.chromium.org/1194013002/diff/20001/content/common/cross_si...
content/common/cross_site_document_classifier.cc:170: };
On 2015/07/01 00:34:54, dsjang1 wrote:
> What was the reason behind removing <?xml from here?

dsjang@: it was causing XML to be logged as HTML, see
https://codereview.chromium.org/1178443002/diff/20001/content/child/site_isol...

Powered by Google App Engine
This is Rietveld 408576698