Source/core/loader/FrameLoader.h - Issue 1194003004: Oilpan: enable appcache + move DocumentLoader to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.h

Issue 1194003004: Oilpan: enable appcache + move DocumentLoader to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add outer loader protection Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/DocumentLoader.cpp ('K') | « Source/core/loader/FrameFetchContextTest.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | Source/core/loader/appcache/ApplicationCacheHost.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/FrameLoader.h

diff --git a/Source/core/loader/FrameLoader.h b/Source/core/loader/FrameLoader.h

index 1aae7db2ff17f2c00bdd134a6d2e6ae384321d12..58e93a708aa075f6a680ff53e52a513f35c68bf8 100644

--- a/Source/core/loader/FrameLoader.h

+++ b/Source/core/loader/FrameLoader.h

@@ -226,9 +226,9 @@ private:

// a new request is being loaded, the old document loader may still be referenced.

// E.g. while a new request is in the "policy" state, the old document loader may

// be consulted in particular as it makes sense to imply certain settings on the new loader.

- RefPtr<DocumentLoader> m_documentLoader;

- RefPtr<DocumentLoader> m_provisionalDocumentLoader;

- RefPtr<DocumentLoader> m_policyDocumentLoader;

+ RefPtrWillBeMember<DocumentLoader> m_documentLoader;

+ RefPtrWillBeMember<DocumentLoader> m_provisionalDocumentLoader;

+ RefPtrWillBeMember<DocumentLoader> m_policyDocumentLoader;

RefPtrWillBeMember<HistoryItem> m_currentItem;

RefPtrWillBeMember<HistoryItem> m_provisionalItem;