Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issue 1193843015: PPC: [turbofan] Fix implementation of Float64Min. (Closed)

Created:
5 years, 6 months ago by MTBrandyberry
Modified:
5 years, 6 months ago
Reviewers:
michael_dawson, dstence
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Fix implementation of Float64Min. The optimized instruction sequences for floating-point min/max do not have the same behaviour as TurboFan's Float(32|64)(Min|Max) functions (incorrect handling for NaN operands). R=dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/b76cf1f802a7967b36d4ac703af81bf9a60d5d56 Cr-Commit-Position: refs/heads/master@{#29234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 2 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 6 months ago (2015-06-23 14:25:20 UTC) #1
dstence
lgtm
5 years, 6 months ago (2015-06-23 14:26:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193843015/1
5 years, 6 months ago (2015-06-23 14:30:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-23 14:56:58 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 14:57:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b76cf1f802a7967b36d4ac703af81bf9a60d5d56
Cr-Commit-Position: refs/heads/master@{#29234}

Powered by Google App Engine
This is Rietveld 408576698