Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(69)

Issue 1193823002: Relocate source code position of VisiblePosition::init() (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Relocate source code position of VisiblePosition::init() This patch relocates |VisiblePosition::init()| after |canonicalPosition()| to avoid having forward function declaration for a preparation of making |canonicalPosition()| a template function to make |VisiblePostion| to work with both a position in DOM tree and a position in composed tree, since |VisiblePostion::init()| calls |canonicalPosition()|, we need to place a template function |canonicalPosition()| before |init()|. Because of |canonicalPosition()| is larger than |init()|, moving |init()| after |canonicalPosition()| yields smaller diff than moving |canonicalPosition()| before |init()|. This patch is a follow up patch of http://crrev.com/1191193002 BUG=n/a TEST=no behavior chagnes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M Source/core/editing/VisiblePosition.cpp View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL Follow up patch for removing a forward declaration of static function.
4 years, 10 months ago (2015-06-19 05:39:30 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-19 05:41:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193823002/1
4 years, 10 months ago (2015-06-19 06:07:35 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 06:48:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197448

Powered by Google App Engine
This is Rietveld 408576698