scripts/slave/recipe_modules/cipd/config.py - Issue 1193813004: cipd recipe_module

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: scripts/slave/recipe_modules/cipd/config.py

Issue 1193813004: cipd recipe_module (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: added ensure_installed Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« scripts/slave/recipe_modules/cipd/api.py ('K') | « scripts/slave/recipe_modules/cipd/api.py ('k') | scripts/slave/recipe_modules/cipd/resources/bootstrap.py » ('j') | scripts/slave/recipe_modules/cipd/resources/bootstrap.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 from recipe_engine.config import config_item_context
	Vadim Sh. 2015/06/29 21:00:46 I personally don't understand how this config stuf I personally don't understand how this config stuff works and why it is needed in CIPD module, imho: api.cipd.ensure_installed(root, packages) is good enough. seanmccullough 2015/06/30 17:39:39 IIRC iannucci@ suggested this approach. I'm fine Show quoted text On 2015/06/29 21:00:46, Vadim Sh. wrote: > I personally don't understand how this config stuff works and why it is needed > in CIPD module, imho: > > api.cipd.ensure_installed(root, packages) is good enough. IIRC iannucci@ suggested this approach. I'm fine with taking it out :) Vadim Sh. 2015/06/30 17:58:35 Yeah, let's keep it simple for now and add it late Show quoted text On 2015/06/30 17:39:39, seanmccullough wrote: > On 2015/06/29 21:00:46, Vadim Sh. wrote: > > I personally don't understand how this config stuff works and why it is needed > > in CIPD module, imho: > > > > api.cipd.ensure_installed(root, packages) is good enough. > > IIRC iannucci@ suggested this approach. I'm fine with taking it out :) Yeah, let's keep it simple for now and add it later if it brings any benefits. seanmccullough 2015/06/30 19:12:03 Done. Show quoted text On 2015/06/30 17:58:35, Vadim Sh. wrote: > On 2015/06/30 17:39:39, seanmccullough wrote: > > On 2015/06/29 21:00:46, Vadim Sh. wrote: > > > I personally don't understand how this config stuff works and why it is > needed > > > in CIPD module, imho: > > > > > > api.cipd.ensure_installed(root, packages) is good enough. > > > > IIRC iannucci@ suggested this approach. I'm fine with taking it out :) > > Yeah, let's keep it simple for now and add it later if it brings any benefits. Done.
	2 from recipe_engine.config import ConfigGroup

	3 from recipe_engine.config import Dict

	4

	5 def BaseConfig(**_kwargs):

	6 # This never gets called.

	7 return ConfigGroup(

	8 packages = Dict(value_type=dict),

	9 )

	10

	11 config_ctx = config_item_context(BaseConfig)

	12

OLD	NEW