Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(87)

Issue 1193813003: Templatize version updateSelectionForMouseDrag in SelectionController (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize version updateSelectionForMouseDrag in SelectionController This patch introduces a template function |updateSelectionForMouseDragAlgorithm<Strategy>| for a preparation of making |updateSelectionForMouseDrag()| to work with both DOM tree and composed tree. Following patch will make |expandSelectionToRespectUserSelectAll()| to check runtime flag |SelectionForWebComponents| and work for either positions in DOM tree or positions in composed tree. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197454

Patch Set 1 #

Patch Set 2 : 2015-06-19T15:56:13 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M Source/core/editing/SelectionController.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/editing/SelectionController.cpp View 1 3 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-19 07:42:03 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-19 07:56:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193813003/20001
4 years, 10 months ago (2015-06-19 07:56:35 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 08:17:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197454

Powered by Google App Engine
This is Rietveld 408576698