Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(60)

Issue 1193813002: New SELECT Popup: Reduce the size of JSON data. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

New SELECT Popup: Reduce the size of JSON data. This CL reduces the size of JSON data which is passed from the origin document to the popup. For example, we pass 'display' CSS property of an OPTION element only if display:none. This CL reduces time to open 43k OPTION popup by 0.5sec on my machine. BUG=500401 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197452

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -38 lines) Patch
M Source/web/PopupMenuImpl.h View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/web/PopupMenuImpl.cpp View 7 chunks +48 lines, -27 lines 0 comments Download
M Source/web/resources/listPicker.js View 2 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tkent
Keishi, please review this.
4 years, 10 months ago (2015-06-19 05:20:46 UTC) #2
keishi
4 years, 10 months ago (2015-06-19 05:22:44 UTC) #3
keishi
LGTM
4 years, 10 months ago (2015-06-19 05:22:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193813002/1
4 years, 10 months ago (2015-06-19 06:33:40 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 07:33:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197452

Powered by Google App Engine
This is Rietveld 408576698