Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.h

Issue 11938007: Don't use request user data during one-click sign in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.h
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.h b/chrome/browser/ui/sync/one_click_signin_helper.h
index 8a35a628333b48d8f2a13488a39fdba3303f6d12..bb8605c7dbbe33d07b1ec2096d242f596ef32ac2 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.h
+++ b/chrome/browser/ui/sync/one_click_signin_helper.h
@@ -73,10 +73,6 @@ class OneClickSigninHelper
virtual ~OneClickSigninHelper();
- // Called only by tests to associate information with a given request.
- static void AssociateWithRequestForTesting(base::SupportsUserData* request,
- const std::string& email);
-
// Returns true if the one-click signin feature can be offered at this time.
// If |email| is not empty, then the profile is checked to see if it's
// already connected to a google account or if the user has already rejected
@@ -110,6 +106,7 @@ class OneClickSigninHelper
// tries to display an infobar in the tab contents identified by the
// child/route id.
static void ShowInfoBarIfPossible(net::URLRequest* request,
+ ProfileIOData* io_data,
int child_id,
int route_id);

Powered by Google App Engine
This is Rietveld 408576698