Don't use request user data during one-click sign in

chrome/browser/ui/sync/one_click_signin_helper_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/content_settings/cookie_settings.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prefs/pref_service_syncable.h"
@@ skipping 47 matching lines @@
  public:
   TestProfileIOData(bool is_incognito, PrefService* pref_service,
                     PrefService* local_state, CookieSettings* cookie_settings)
       : ProfileIOData(is_incognito) {
     // Initialize the IO members required for these tests, but keep them on
     // this thread since we don't use a background thread here.
     google_services_username()->Init(prefs::kGoogleServicesUsername,
                                      pref_service);
     reverse_autologin_enabled()->Init(prefs::kReverseAutologinEnabled,
                                       pref_service);
+    reverse_autologin_pending_email()->Init(
+        prefs::kReverseAutologinPendingEmail, pref_service);
     one_click_signin_rejected_email_list()->Init(
         prefs::kReverseAutologinRejectedEmailList, pref_service);
 
     google_services_username_pattern()->Init(
         prefs::kGoogleServicesUsernamePattern, local_state);
 
     sync_disabled()->Init(prefs::kSyncManaged, pref_service);
 
     set_signin_names_for_testing(new SigninNamesOnIOThread());
     SetCookieSettingsForTesting(cookie_settings);
@@ skipping 226 matching lines @@
       fub_thread_(content::BrowserThread::FILE_USER_BLOCKING, &message_loop_),
       io_thread_(content::BrowserThread::IO, &message_loop_) {
 }
 
 OneClickSigninHelperIOTest::~OneClickSigninHelperIOTest() {
 }
 
 void OneClickSigninHelperIOTest::SetUp() {
   OneClickSigninHelperTest::SetUp();
   ASSERT_TRUE(testing_profile_manager_.SetUp());
-  OneClickSigninHelper::AssociateWithRequestForTesting(&request_,
-                                                       "user@gmail.com");
 }
 
 TestProfileIOData* OneClickSigninHelperIOTest::CreateTestProfileIOData(
     bool is_incognito) {
   PrefService* pref_service = profile_->GetPrefs();
   PrefService* local_state = g_browser_process->local_state();
   CookieSettings* cookie_settings =
       CookieSettings::Factory::GetForProfile(profile_);
   TestProfileIOData* io_data = new TestProfileIOData(
       is_incognito, pref_service, local_state, cookie_settings);
+  io_data->reverse_autologin_pending_email()->SetValue("user@gmail.com");
   return io_data;
 }
 
 TEST_F(OneClickSigninHelperTest, CanOfferNoContents) {
   int error_message_id = 0;
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(
       NULL, OneClickSigninHelper::CAN_OFFER_FOR_INTERSTITAL_ONLY,
       "user@gmail.com", &error_message_id));
   EXPECT_EQ(0, error_message_id);
   EXPECT_FALSE(OneClickSigninHelper::CanOffer(
@@ skipping 354 matching lines @@
             OneClickSigninHelper::CanOfferOnIOThreadImpl(
                 valid_gaia_url_, "", &request_, io_data.get()));
 
   // Simulate a policy disabling sync by writing kSyncManaged directly.
   profile_->GetTestingPrefService()->SetManagedPref(
       prefs::kSyncManaged, base::Value::CreateBooleanValue(true));
   EXPECT_EQ(OneClickSigninHelper::DONT_OFFER,
             OneClickSigninHelper::CanOfferOnIOThreadImpl(
                 valid_gaia_url_, "", &request_, io_data.get()));
 }