Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: Source/core/dom/Document.idl

Issue 1193793003: bindings: Makes almost all attributes accessor-type properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | Source/core/dom/XMLDocument.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index 5b4d664ef087c0b66ec9732b1ae8e55c8f6f363c..29f44df06a75ecaed5313df21c697b1c4a9833d8 100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -80,6 +80,12 @@ interface Document : Node {
// https://html.spec.whatwg.org/#the-document-object
// resource metadata management
+
+ // Inheritance of [Unforgeable] attributes is not supported. So we have to
+ // define the same unforgeable attributes in derived interfaces as well.
+ // See that HTMLDocument and XMLDocument redefine 'location' attribute.
+ // Keep all the definitions consistent.
+ // TODO(yukishiino): Support inheritance of attributes defined on instance.
[PutForwards=href, Unforgeable] readonly attribute Location? location;
[RaisesException=Setter] attribute DOMString domain;
readonly attribute DOMString referrer;
« no previous file with comments | « Source/bindings/tests/results/modules/V8TestInterface5.cpp ('k') | Source/core/dom/XMLDocument.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698