Source/web/PopupMenuImpl.h - Issue 1193793002: New SELECT Popup: Remove O(N^2) scan for OPTIONs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/PopupMenuImpl.h

Issue 1193793002: New SELECT Popup: Remove O(N^2) scan for OPTIONs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/PopupMenuImpl.h

diff --git a/Source/web/PopupMenuImpl.h b/Source/web/PopupMenuImpl.h

index 4cb6ace4426910a223429c36d24e04fdb73a3e2e..8189a71bb429829fde79bbb1682ac703bf0e540f 100644

--- a/Source/web/PopupMenuImpl.h

+++ b/Source/web/PopupMenuImpl.h

@@ -31,9 +31,9 @@ private:

PopupMenuImpl(ChromeClientImpl*, PopupMenuClient*);

bool hasTooManyItemsForStyling();

- void addOption(HTMLOptionElement&, bool enableExtraStyling, SharedBuffer*);

- void addOptGroup(HTMLOptGroupElement&, bool enableExtraStyling, SharedBuffer*);

- void addSeparator(HTMLHRElement&, bool enableExtraStyling, SharedBuffer*);

+ void addOption(HTMLOptionElement&, int& listIndex, bool enableExtraStyling, SharedBuffer*);

+ void addOptGroup(HTMLOptGroupElement&, int& listIndex, bool enableExtraStyling, SharedBuffer*);

+ void addSeparator(HTMLHRElement&, int& listIndex, bool enableExtraStyling, SharedBuffer*);

void addElementStyle(HTMLElement&, bool enableExtraStyling, SharedBuffer*);

// PopupMenu functions:

« no previous file with comments | « no previous file | Source/web/PopupMenuImpl.cpp » ('j') | no next file with comments »