Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(126)

Issue 1193793002: New SELECT Popup: Remove O(N^2) scan for OPTIONs. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

New SELECT Popup: Remove O(N^2) scan for OPTIONs. HTMLOptionElement::listIndex() is O(N), and we need to call it for each of OPTIONs. After this patch, PopupMenuImpl calculate listIndex incrementally while iterating over OPTIONs. This CL makes writeDocument() 16x faster with 43k OPTIONs. BUG=500401 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197429

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M Source/web/PopupMenuImpl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/web/PopupMenuImpl.cpp View 4 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Keishi, would you review this please?
4 years, 10 months ago (2015-06-19 04:03:16 UTC) #2
keishi
lgtm
4 years, 10 months ago (2015-06-19 04:06:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193793002/1
4 years, 10 months ago (2015-06-19 04:07:48 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 04:11:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197429

Powered by Google App Engine
This is Rietveld 408576698