Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: Source/core/editing/VisiblePosition.cpp

Issue 1193783002: Templatize canonicalizeCandidate() in VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-06-19T12:59:53 Mark |static| Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/VisiblePosition.cpp
diff --git a/Source/core/editing/VisiblePosition.cpp b/Source/core/editing/VisiblePosition.cpp
index 046f5b6883f9c9c47e687b62db901d27e73890bd..76cdecdeae20823bf738628fe401a75a214cae96 100644
--- a/Source/core/editing/VisiblePosition.cpp
+++ b/Source/core/editing/VisiblePosition.cpp
@@ -542,12 +542,13 @@ VisiblePosition VisiblePosition::skipToEndOfEditingBoundary(const VisiblePositio
return firstEditableVisiblePositionAfterPositionInRoot(pos.deepEquivalent(), highestRoot);
}
-static Position canonicalizeCandidate(const Position& candidate)
+template <typename PositionType>
+static PositionType canonicalizeCandidate(const PositionType& candidate)
{
if (candidate.isNull())
- return Position();
+ return PositionType();
ASSERT(candidate.isCandidate());
- Position upstream = candidate.upstream();
+ PositionType upstream = candidate.upstream();
if (upstream.isCandidate())
return upstream;
return candidate;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698