Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(51)

Issue 1193783002: Templatize canonicalizeCandidate() in VisiblePosition (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Templatize canonicalizeCandidate() in VisiblePosition This patch makes |canonicalizeCandidate()| in |VisiblePosition| to a template function with template parameter |PositionType|, which takes either |Position| for DOM tree or |PositionInComposedTree|. This patch is a preparation to make |VisiblePositon| to work with a position in composed tree for selection for web component. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1106433002. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197447

Patch Set 1 #

Patch Set 2 : 2015-06-19T12:59:53 Mark |static| #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M Source/core/editing/VisiblePosition.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-19 04:00:53 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-19 04:05:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193783002/20001
4 years, 10 months ago (2015-06-19 04:05:27 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-19 06:44:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197447

Powered by Google App Engine
This is Rietveld 408576698