Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1193763004: Expose the asset_bundle service in SkyShell (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson_old, eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Expose the asset_bundle service in SkyShell The plan is to use this service for game assets and offline assets. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f7ad05b9c21da49724403658b450f43d794f2312

Patch Set 1 #

Patch Set 2 : Update for API change #

Total comments: 1

Patch Set 3 : Use a source_set #

Patch Set 4 : nit #

Patch Set 5 : use source_set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -59 lines) Patch
M mojo/services/BUILD.gn View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M sky/sdk/lib/mojo/asset_bundle.dart View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M sky/shell/BUILD.gn View 1 2 4 chunks +40 lines, -52 lines 0 comments Download
M sky/shell/ui/internals.h View 1 1 chunk +19 lines, -3 lines 0 comments Download
M sky/shell/ui/internals.cc View 1 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-19 00:49:04 UTC) #1
eseidel
lgtm https://codereview.chromium.org/1193763004/diff/20001/sky/shell/BUILD.gn File sky/shell/BUILD.gn (right): https://codereview.chromium.org/1193763004/diff/20001/sky/shell/BUILD.gn#newcode81 sky/shell/BUILD.gn:81: ] + common_files Why use a variable instead ...
5 years, 6 months ago (2015-06-22 15:59:43 UTC) #3
abarth-chromium
On 2015/06/22 at 15:59:43, eseidel wrote: > Why use a variable instead of a source ...
5 years, 6 months ago (2015-06-22 16:02:16 UTC) #4
abarth-chromium
Managed to get source_set working in this CL.
5 years, 6 months ago (2015-06-23 04:32:41 UTC) #5
abarth-chromium
5 years, 6 months ago (2015-06-23 04:32:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:70001) manually as
f7ad05b9c21da49724403658b450f43d794f2312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698