Source/core/css/CSSPrimitiveValue.cpp - Issue 1193753002: Serialize zIndex as an integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 1193753002: Serialize zIndex as an integer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix CSSCalculationValue.cpp Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSPrimitiveValue.cpp

diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp

index 606a36e4e8f21f6cee51163d50559a86d7f89fce..a4eb31adb59c44b655d1fcb7e70f63912d60a1b1 100644

--- a/Source/core/css/CSSPrimitiveValue.cpp

+++ b/Source/core/css/CSSPrimitiveValue.cpp

@@ -438,6 +438,7 @@ void CSSPrimitiveValue::cleanup()

#endif

break;

case CSS_NUMBER:

+ case CSS_INTEGER:

case CSS_PERCENTAGE:

case CSS_EMS:

case CSS_QEM:

@@ -854,6 +855,7 @@ const char* CSSPrimitiveValue::unitTypeToString(UnitType type)

{

switch (type) {

case CSS_NUMBER:

+ case CSS_INTEGER:

return "";

case CSS_PERCENTAGE:

return "%";

@@ -945,6 +947,9 @@ String CSSPrimitiveValue::customCSSText() const

case CSS_UNKNOWN:

// FIXME

break;

+ case CSS_INTEGER:

+ text = String::format("%d", getIntValue());

+ break;

case CSS_NUMBER:

case CSS_PERCENTAGE:

case CSS_EMS: