Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1193753002: Serialize zIndex as an integer (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Serialize zIndex as an integer Serialize zIndex as an integer by adding CSS_INTEGER to UnitType, which prints the CSSPrimitiveValue number as an integer. Before this patch zIndex was serialized using scientific notation if that was the shortest notation, causing the jquery specific problem in issue 503088. BUG=501522, 503088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198254

Patch Set 1 #

Patch Set 2 : Fix more #

Patch Set 3 : Fix regression and add test #

Total comments: 1

Patch Set 4 : Fix CSSCalculationValue.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
A LayoutTests/fast/css/large-integer-value-serializing.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/animation/DoubleStyleInterpolation.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rwlbuis
PTAL.
5 years, 6 months ago (2015-06-26 02:19:10 UTC) #2
Timothy Loh
Seems fine as long as we eventually plan to make all the other <integer>-valued properties ...
5 years, 5 months ago (2015-06-29 04:29:50 UTC) #4
rwlbuis
On 2015/06/29 04:29:50, Timothy Loh wrote: > Seems fine as long as we eventually plan ...
5 years, 5 months ago (2015-07-01 00:33:28 UTC) #5
Timothy Loh
lgtm
5 years, 5 months ago (2015-07-03 01:50:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193753002/60001
5 years, 5 months ago (2015-07-03 01:59:52 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 03:13:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198254

Powered by Google App Engine
This is Rietveld 408576698