Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1193733004: Factor out the analyzer part of shelldb so we can reuse it in tests. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Factor out the analyzer part of shelldb so we can reuse it in tests. This also introduces a new set_build_dir command to shelldb so you can set the build directory without starting sky. R=abarth@chromium.org, abarth, eseidel Committed: https://chromium.googlesource.com/external/mojo/+/d50a9dd01cd1af6123fcbcaa7f19da67cd270bb4

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -45 lines) Patch
M sky/tools/shelldb View 1 2 5 chunks +28 lines, -45 lines 0 comments Download
A sky/tools/skyanalyzer View 1 1 chunk +79 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm https://codereview.chromium.org/1193733004/diff/20001/sky/tools/skyanalyzer File sky/tools/skyanalyzer (right): https://codereview.chromium.org/1193733004/diff/20001/sky/tools/skyanalyzer#newcode47 sky/tools/skyanalyzer:47: parser.add_argument('app_path', type=str) Why --congratulate but no -- for ...
5 years, 6 months ago (2015-06-18 23:49:25 UTC) #2
Hixie
On 2015/06/18 at 23:49:25, abarth wrote: > lgtm > > https://codereview.chromium.org/1193733004/diff/20001/sky/tools/skyanalyzer > File sky/tools/skyanalyzer (right): ...
5 years, 6 months ago (2015-06-18 23:54:34 UTC) #3
Hixie
5 years, 6 months ago (2015-06-18 23:54:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d50a9dd01cd1af6123fcbcaa7f19da67cd270bb4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698