Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1193713002: Demonstrate that we don't crash on a bogus import (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Demonstrate that we don't crash on a bogus import Fixes #167 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/b514027887ad0d9a43e03f20cc65d94dcee41561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
A sky/tests/raw/bogus_import.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A + sky/tests/raw/bogus_import-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-18 16:29:45 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-06-18 17:29:15 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-18 19:13:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b514027887ad0d9a43e03f20cc65d94dcee41561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698