Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1193673002: Split setting array length from handling new Array(non-number) (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split setting array length from handling new Array(non-number) BUG= Committed: https://crrev.com/be8528b3bda429bcd2670b8ef39e37d9c341ef13 Cr-Commit-Position: refs/heads/master@{#29144}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed nit #

Patch Set 3 : Make GCC happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -82 lines) Patch
M src/elements.cc View 1 2 1 chunk +62 lines, -82 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
ptal There's more cleanup to be done, but lets start with this.
5 years, 6 months ago (2015-06-18 14:05:18 UTC) #2
Jakob Kummerow
LGTM! https://codereview.chromium.org/1193673002/diff/1/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/1193673002/diff/1/src/elements.cc#newcode1728 src/elements.cc:1728: // even though the proposed length was a ...
5 years, 6 months ago (2015-06-18 19:22:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193673002/20001
5 years, 6 months ago (2015-06-19 09:08:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/3590)
5 years, 6 months ago (2015-06-19 09:18:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193673002/40001
5 years, 6 months ago (2015-06-19 10:57:19 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-19 11:21:32 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 11:21:48 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/be8528b3bda429bcd2670b8ef39e37d9c341ef13
Cr-Commit-Position: refs/heads/master@{#29144}

Powered by Google App Engine
This is Rietveld 408576698