Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 1193633003: [strong] Add tests for loading from proxy, super, with access checks (Closed)

Created:
5 years, 6 months ago by conradw
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Add tests for loading from proxy, super, with access checks Followup for https://codereview.chromium.org/1168093002/ These seem to already function correctly without the need for further runtime changes. There will be a final follow-up for interceptors. BUG=v8:3956 LOG=N Committed: https://crrev.com/ea4e568363f48955e7de6b538e559132e9899c86 Cr-Commit-Position: refs/heads/master@{#29389}

Patch Set 1 #

Patch Set 2 : add positive tests for access checks #

Total comments: 4

Patch Set 3 : cl feedback #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -1 line) Patch
M test/cctest/test-api.cc View 1 2 3 1 chunk +158 lines, -0 lines 0 comments Download
M test/mjsunit/strong/load-builtins.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/strong/load-proxy.js View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
A test/mjsunit/strong/load-super.js View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
conradw
PTAL
5 years, 6 months ago (2015-06-18 13:42:14 UTC) #3
conradw
On 2015/06/18 13:42:14, conradw wrote: > PTAL Landing this should wait until issues with the ...
5 years, 6 months ago (2015-06-18 13:43:13 UTC) #4
rossberg
lgtm https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc#newcode21442 test/cctest/test-api.cc:21442: TEST(StrongModeAccessChecks) { Can we also have a test ...
5 years, 5 months ago (2015-06-30 12:38:03 UTC) #5
conradw
https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/1193633003/diff/40001/test/cctest/test-api.cc#newcode21442 test/cctest/test-api.cc:21442: TEST(StrongModeAccessChecks) { On 2015/06/30 12:38:03, rossberg wrote: > Can ...
5 years, 5 months ago (2015-06-30 15:12:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193633003/80001
5 years, 5 months ago (2015-06-30 17:11:44 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 5 months ago (2015-06-30 17:13:15 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/ea4e568363f48955e7de6b538e559132e9899c86 Cr-Commit-Position: refs/heads/master@{#29389}
5 years, 5 months ago (2015-06-30 17:13:30 UTC) #11
Michael Achenbach
5 years, 5 months ago (2015-06-30 18:42:01 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:80001) has been created in
https://codereview.chromium.org/1218123003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks gc stress:
http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%202/build....

Powered by Google App Engine
This is Rietveld 408576698