Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: ui/android/java/src/org/chromium/ui/base/ResourceBundle.java

Issue 1193613002: Convert Android WebView to store locale .pak files as res/raw resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-extractor-init
Patch Set: rebase again Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/android/java/src/org/chromium/ui/base/ResourceBundle.java
diff --git a/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java b/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java
index a17975c3a723fc06dc18301859f218faa4c74f52..b29a291b873a778113900c6cca4bc16b52b81b5b 100644
--- a/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java
+++ b/ui/android/java/src/org/chromium/ui/base/ResourceBundle.java
@@ -5,28 +5,86 @@
package org.chromium.ui.base;
import android.content.Context;
-import android.content.res.AssetFileDescriptor;
-import android.content.res.AssetManager;
+import android.content.res.Resources;
+import android.content.res.TypedArray;
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
+import org.chromium.base.ResourceExtractor;
+import org.chromium.base.ThreadUtils;
+import org.chromium.base.annotations.SuppressFBWarnings;
-import java.io.IOException;
+import java.io.File;
+import java.util.Locale;
/**
- * This class provides the resource bundle related methods for the native library.
+ * This class provides the resource bundle related methods for the native
+ * library.
*/
@JNINamespace("ui")
-class ResourceBundle {
- @CalledByNative
- static boolean assetContainedInApk(Context ctx, String filename) {
+public class ResourceBundle {
+ private static ResourceExtractor.ResourceEntry[] sActiveLocaleResources;
+
+ /**
+ * Applies the reverse mapping done by locale_pak_resources.py.
+ */
+ private static String toChromeLocaleName(String srcFileName) {
+ srcFileName = srcFileName.replace(".lpak", ".pak");
+ String[] parts = srcFileName.split("_");
+ if (parts.length > 1) {
+ int dotIdx = parts[1].indexOf('.');
+ return parts[0] + "-" + parts[1].substring(0, dotIdx).toUpperCase(Locale.ENGLISH)
+ + parts[1].substring(dotIdx);
+ }
+ return srcFileName;
+ }
+
+ /**
+ * Initializes the list of locale packs for the active locale that are
+ * present within the apk.
+ *
+ * @param context Any context
+ * @param localePaksResId Resource ID locale_paks (generated by
+ * locale_pak_resources.py)
+ */
+ @SuppressFBWarnings("LI_LAZY_INIT_UPDATE_STATIC") // Not thread-safe.
+ public static void initializeLocalePaks(Context context, int localePaksResId) {
+ ThreadUtils.assertOnUiThread();
+ assert sActiveLocaleResources == null;
+ Resources resources = context.getResources();
+ TypedArray resIds = resources.obtainTypedArray(localePaksResId);
try {
- AssetManager am = ctx.getAssets();
- AssetFileDescriptor afd = am.openFd(filename);
- afd.close();
- return true;
- } catch (IOException e) {
- return false;
+ int len = resIds.length();
+ sActiveLocaleResources = new ResourceExtractor.ResourceEntry[len];
+ for (int i = 0; i < len; ++i) {
+ int resId = resIds.getResourceId(i, 0);
+ String resPath = resources.getString(resId);
+ String srcBaseName = new File(resPath).getName();
+ String dstBaseName = toChromeLocaleName(srcBaseName);
+ sActiveLocaleResources[i] = new ResourceExtractor.ResourceEntry(resId, resPath,
+ dstBaseName);
+ }
+ } finally {
+ resIds.recycle();
+ }
+ }
+
+ @SuppressFBWarnings("MS_EXPOSE_REP") // Don't modify the array.
+ public static ResourceExtractor.ResourceEntry[] getActiveLocaleResources() {
+ return sActiveLocaleResources;
+ }
+
+ @CalledByNative
+ private static String getLocalePakResourcePath(String locale) {
+ if (sActiveLocaleResources == null) {
+ return null;
+ }
+ String fileName = locale + ".pak";
+ for (ResourceExtractor.ResourceEntry entry : sActiveLocaleResources) {
+ if (fileName.equals(entry.extractedFileName)) {
+ return entry.pathWithinApk;
+ }
}
+ return null;
}
}

Powered by Google App Engine
This is Rietveld 408576698