Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: ui/base/resource/resource_bundle_android.h

Issue 1193613002: Convert Android WebView to store locale .pak files as res/raw resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-extractor-init
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/resource/resource_bundle_android.h
diff --git a/ui/base/resource/resource_bundle_android.h b/ui/base/resource/resource_bundle_android.h
index 8708f734a60cc78a7d3c659be7c4e2d694169338..478436c59483ba3507ae6965dfa6ba57efa7c4d5 100644
--- a/ui/base/resource/resource_bundle_android.h
+++ b/ui/base/resource/resource_bundle_android.h
@@ -25,8 +25,11 @@ UI_BASE_EXPORT int GetMainAndroidPackFd(
UI_BASE_EXPORT int GetCommonResourcesPackFd(
base::MemoryMappedFile::Region* out_region);
-// Checks whether the locale data pak is contained within the .apk.
-bool AssetContainedInApk(const std::string& filename);
+// Returns the path within the apk for the given locale's .pak file, or an
+// empty string if it doesn't exist.
+// Only locale paks for the active Android language can be retrieved.
+UI_BASE_EXPORT std::string GetPathForAndroidLocalePakWithinApk(
Yaron 2015/06/19 15:01:30 that's a mouthful
agrieve 2015/06/23 15:33:22 Yeah, I think it's worth it though: - Need to say
+ const std::string& locale);
bool RegisterResourceBundleAndroid(JNIEnv* env);

Powered by Google App Engine
This is Rietveld 408576698