Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 1193593002: DevTools: Align flamechart ruler with overview (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
caseq, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Align flamechart ruler with overview When the entire recording is selected make the flamechart rulers match the overview ones. Some contents may be hidden behind vertical scroller thought, but that's not a problem as it is possible to zoom in. Note that this schema is currently used for MacOS. Drive-by: Fixed on-hover selection misalign on flamechart. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M Source/devtools/front_end/ui_lazy/FlameChart.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ui_lazy/flameChart.css View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alph
4 years, 10 months ago (2015-06-17 18:44:13 UTC) #2
alph
4 years, 10 months ago (2015-06-18 15:57:21 UTC) #4
yurys
lgtm
4 years, 10 months ago (2015-06-18 16:09:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193593002/1
4 years, 10 months ago (2015-06-18 16:10:33 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59537)
4 years, 10 months ago (2015-06-18 18:23:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193593002/1
4 years, 10 months ago (2015-06-18 21:07:05 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 21:44:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197397

Powered by Google App Engine
This is Rietveld 408576698