Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1193553002: simplify release-proc for SkData, removing unneeded size param (Closed)

Created:
5 years, 6 months ago by reed1
Modified:
5 years, 6 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

simplify release-proc for SkData, removing unneeded size param request https://codereview.chromium.org/1184953005 to land first BUG=skia: Committed: https://skia.googlesource.com/skia/+/6b7f34e34cc0ce397ce5e4ddc0c244f372b4f840

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M include/core/SkData.h View 1 4 chunks +21 lines, -5 lines 0 comments Download
M src/core/SkData.cpp View 1 6 chunks +30 lines, -8 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DataRefTest.cpp View 1 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193553002/1
5 years, 6 months ago (2015-06-17 14:17:46 UTC) #2
reed1
5 years, 6 months ago (2015-06-17 15:34:07 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193553002/20001
5 years, 6 months ago (2015-06-17 15:34:13 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 15:39:55 UTC) #9
f(malita)
lgtm
5 years, 6 months ago (2015-06-17 15:43:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193553002/20001
5 years, 6 months ago (2015-06-17 16:57:58 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 16:58:31 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/6b7f34e34cc0ce397ce5e4ddc0c244f372b4f840

Powered by Google App Engine
This is Rietveld 408576698