Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 119353003: Revert "Revert "begin to remove SkLONGLONG and wean Skia off of Sk64"" (Closed)

Created:
7 years ago by reed1
Modified:
7 years ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "Revert "begin to remove SkLONGLONG and wean Skia off of Sk64"" This reverts commit 15b986baf026a3da5e2cac8106a1b753df242c39. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12796

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -114 lines) Patch
M include/config/SkUserConfig.h View 1 chunk +0 lines, -6 lines 0 comments Download
M include/core/Sk64.h View 2 chunks +10 lines, -3 lines 0 comments Download
M include/core/SkFixed.h View 1 2 chunks +1 line, -17 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +5 lines, -5 lines 0 comments Download
M include/utils/SkCamera.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/core/Sk64.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/core/SkMath.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/MathTest.cpp View 1 3 chunks +1 line, -37 lines 0 comments Download
M tests/Sk64Test.cpp View 6 chunks +22 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
reed1
SkFixedSquare is not implemented on linux, but I think it is not needed...
7 years ago (2013-12-19 22:30:32 UTC) #1
reed1
7 years ago (2013-12-20 14:24:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r12796 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698