Issue 1193513007: Rename EventListenerNode to Listener

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1193513007: Rename EventListenerNode to Listener (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Rename EventListenerNode to Listener The basic widgets are going to be used many, many times, so we want them to have short, snappy names. Also, give the Widget argument to Listener the name |child| for consistency. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/063fb6e71242163a8bdd2b2087c2964152606e16

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -29 lines)			Patch
M	sky/sdk/lib/editing2/input.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/widgets/basic.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/button_base.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/dialog.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/drawer.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/widgets/icon_button.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/material_button.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/menu_item.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/modal_overlay.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/radio.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/scrollable.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/toggleable.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

Committed patchset #1 (id:1) manually as 063fb6e71242163a8bdd2b2087c2964152606e16 (presubmit successful).

5 years, 6 months ago (2015-06-17 14:39:29 UTC) #2

Message was sent while issue was closed.

lgtm