Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(50)

Issue 1193503002: Oilpan: Marking time measurement should not measure the time taken in postGC() (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Marking time measurement should not measure the time taken in postGC() When we enable GC_PROFILING, postGC() does a lot of time-consuming work. So it shouldn't be counted as a marking time (otherwise we will confuse the marking time estimation). This change will have no effect on builds where GC_PROFILING disabled because postGC() will do almost nothing in those builds. BUG=474470 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/heap/Heap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
haraken
PTAL
4 years, 10 months ago (2015-06-17 06:25:02 UTC) #2
Yuta Kitamura
LGTM as long as other tasks in postGC are short enough. I was thinking something ...
4 years, 10 months ago (2015-06-17 07:24:43 UTC) #3
haraken
> I was thinking something that deducts only the overhead > from tracing, but I'm ...
4 years, 10 months ago (2015-06-17 07:46:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193503002/1
4 years, 10 months ago (2015-06-17 07:46:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/59212)
4 years, 10 months ago (2015-06-17 09:46:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193503002/1
4 years, 10 months ago (2015-06-17 10:24:16 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 13:09:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197258

Powered by Google App Engine
This is Rietveld 408576698