Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1193493003: Modernize atomics in SkTaskGroup's threadpool. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Modernize atomics in SkTaskGroup's threadpool. - Use SkAtomic<int32_t> for pending work count so we're statically forced to operate on it with atomic methods. - Replacing old methods like sk_atomic_inc/dec gives us finer control over which barriers we need for each operation. No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/942e99b9c411d093851db8d12c8357f409563007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M include/core/SkAtomics.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/core/SkTaskGroup.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkTaskGroup.cpp View 8 chunks +24 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 6 months ago (2015-06-17 12:39:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193493003/1
5 years, 6 months ago (2015-06-17 12:41:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-17 12:46:48 UTC) #6
bungeman-skia
Unless you're being really sneaky, this looks like it's doing the same thing it did ...
5 years, 6 months ago (2015-06-17 14:30:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193493003/1
5 years, 6 months ago (2015-06-17 14:52:50 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 14:53:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/942e99b9c411d093851db8d12c8357f409563007

Powered by Google App Engine
This is Rietveld 408576698