Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1193463004: Removing canvas/philip layout tests from virtual test suites (Closed)

Created:
4 years, 10 months ago by Justin Novosad
Modified:
4 years, 10 months ago
Reviewers:
Stephen White
CC:
blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing canvas/philip layout tests from virtual test suites We are getting very little differential test coverage from running these tests in the gpu and display_list_2d_canvas suites, and they add significant weight to the bot cycle time. This change, removes the tests from those suites. BUG=501117 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197235

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -864 lines) Patch
M LayoutTests/MSANExpectations View 1 chunk +0 lines, -5 lines 0 comments Download
M LayoutTests/TestExpectations View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/VirtualTestSuites View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/platform/android/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/platform/android/virtual/gpu/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/android/virtual/gpu/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/platform/android/virtual/gpu/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/platform/linux-x86/virtual/display_list_2d_canvas/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/linux-x86/virtual/display_list_2d_canvas/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/linux/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/linux/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/platform/mac-mountainlion/virtual/display_list_2d_canvas/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac-mountainlion/virtual/display_list_2d_canvas/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.behind-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.beside-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.cylinder-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.shape2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.gradient.radial.touch3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.line.width.basic-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.line.width.transformed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.shadow.enable.blur-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.transformation.setTransform.skewed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/canvas/philip/tests/2d.transformation.transform.skewed-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win-xp/virtual/display_list_2d_canvas/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win-xp/virtual/display_list_2d_canvas/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win-xp/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/platform/win/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/win/virtual/gpu/canvas/philip/tests/2d.gradient.radial.outside3-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/platform/win/virtual/gpu/canvas/philip/tests/2d.pattern.paint.norepeat.coord3-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/win/virtual/gpu/canvas/philip/tests/2d.pattern.paint.repeatx.coord1-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/win/virtual/gpu/canvas/philip/tests/2d.pattern.paint.repeaty.coord1-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/win/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/display_list_2d_canvas/canvas/philip/README.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/display_list_2d_canvas/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/README.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.composite.operation.clear-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.drawImage.broken-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.drawImage.image.incomplete.omitted-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.drawImage.outsidesource-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.fillStyle.parse.rgb-eof-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.fillStyle.parse.rgba-eof-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve1-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.path.arcTo.shape.curve2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.pattern.image.broken-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.shadow.canvas.transparent.2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.shadow.image.transparent.2-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.notinpage-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.draw.text.metrics-expected.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D LayoutTests/virtual/gpu/canvas/philip/tests/2d.text.measure.width.space-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193463004/1
4 years, 10 months ago (2015-06-16 22:57:08 UTC) #2
Justin Novosad
PTAL
4 years, 10 months ago (2015-06-16 22:57:10 UTC) #4
Stephen White
LGTM
4 years, 10 months ago (2015-06-16 22:58:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193463004/1
4 years, 10 months ago (2015-06-16 23:33:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66917)
4 years, 10 months ago (2015-06-17 01:49:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193463004/1
4 years, 10 months ago (2015-06-17 05:09:36 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2015-06-17 06:07:53 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197235

Powered by Google App Engine
This is Rietveld 408576698