Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1193453005: Add some basic tests for the material buttons (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
jackson_old, Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add some basic tests for the material buttons Specifically, RaisedButton, FlatButton, and FloatingActionButton. These just test that these classes work in their default configurations. R=ianh@google.com, jackson@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc98dbae13867a3496a5b39ca285b5cf00053ea9

Patch Set 1 #

Patch Set 2 : Less boilerplate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -0 lines) Patch
M sky/tests/resources/display_list.dart View 1 2 chunks +28 lines, -0 lines 0 comments Download
A sky/tests/widgets/buttons.dart View 1 1 chunk +28 lines, -0 lines 0 comments Download
A sky/tests/widgets/buttons-expected.txt View 1 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 6 months ago (2015-06-16 20:19:00 UTC) #1
abarth-chromium
Now with less boilerplate
5 years, 6 months ago (2015-06-16 20:47:52 UTC) #2
Hixie
lgtm
5 years, 6 months ago (2015-06-16 23:48:01 UTC) #4
abarth-chromium
5 years, 6 months ago (2015-06-17 00:03:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dc98dbae13867a3496a5b39ca285b5cf00053ea9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698