Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1193453004: Add a note to SkGlobalInitialization_chromium.cpp. (Closed)

Created:
5 years, 6 months ago by mtklein_C
Modified:
5 years, 6 months ago
Reviewers:
Stephen White, hcm, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a note to SkGlobalInitialization_chromium.cpp. BUG=chromium:486947 Committed: https://skia.googlesource.com/skia/+/921827bbc78717f514ebd11bf55ac0dd2fe9308c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/ports/SkGlobalInitialization_chromium.cpp View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtklein_C
5 years, 6 months ago (2015-06-16 19:12:29 UTC) #2
hcm
On 2015/06/16 19:12:29, mtklein_C wrote: lgtm, thanks
5 years, 6 months ago (2015-06-16 19:15:46 UTC) #3
Stephen White
LGTM too. I had this on the back burner and forgot about it.. much appreciated!
5 years, 6 months ago (2015-06-16 20:11:06 UTC) #4
mtklein
Me too. We can thank Heather. :)
5 years, 6 months ago (2015-06-16 20:17:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193453004/1
5 years, 6 months ago (2015-06-16 20:17:34 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 20:23:08 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/921827bbc78717f514ebd11bf55ac0dd2fe9308c

Powered by Google App Engine
This is Rietveld 408576698