Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: Source/platform/graphics/paint/DrawingDisplayItem.h

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ready for review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/paint/DrawingDisplayItem.h
diff --git a/Source/platform/graphics/paint/DrawingDisplayItem.h b/Source/platform/graphics/paint/DrawingDisplayItem.h
index 3e2b721d5b64062928c3557cee82b8d5903152bb..1d373cac0b26d253e7b40c7935825a115a416774 100644
--- a/Source/platform/graphics/paint/DrawingDisplayItem.h
+++ b/Source/platform/graphics/paint/DrawingDisplayItem.h
@@ -25,21 +25,24 @@ public:
DrawingDisplayItem(const DisplayItemClientWrapper& client, Type type, PassRefPtr<const SkPicture> picture)
: DisplayItem(client, type)
, m_picture(picture && picture->approximateOpCount() ? picture : nullptr)
-#if ENABLE(ASSERT)
- , m_underInvalidationCheckingMode(CheckPicture)
-#endif
{
ASSERT(isDrawingType(type));
}
- static PassOwnPtr<DrawingDisplayItem> create(const DisplayItemClientWrapper& client, Type type, PassRefPtr<const SkPicture> picture)
+#if ENABLE(ASSERT)
+ DrawingDisplayItem(const DisplayItemClientWrapper& client, Type type, PassRefPtr<const SkPicture> picture, UnderInvalidationCheckingMode underInvalidationCheckingMode)
+ : DisplayItem(client, type)
+ , m_picture(picture && picture->approximateOpCount() ? picture : nullptr)
+ , m_underInvalidationCheckingMode(underInvalidationCheckingMode)
{
- return adoptPtr(new DrawingDisplayItem(client, type, picture));
+ ASSERT(isDrawingType(type));
}
+#endif
- virtual void replay(GraphicsContext&);
- virtual void appendToWebDisplayItemList(WebDisplayItemList*) const override;
- virtual bool drawsContent() const override;
+ void replay(GraphicsContext&) override;
+ void appendToWebDisplayItemList(WebDisplayItemList*) const override;
+ void appendByMoving(DisplayItems&) override;
+ bool drawsContent() const override;
const SkPicture* picture() const { return m_picture.get(); }

Powered by Google App Engine
This is Rietveld 408576698