Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3243)

Unified Diff: Source/platform/graphics/paint/ClipRecorder.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ready for review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/paint/ClipRecorder.cpp
diff --git a/Source/platform/graphics/paint/ClipRecorder.cpp b/Source/platform/graphics/paint/ClipRecorder.cpp
index 89471735da5e17201d0753c382e0102209552f18..d4fbcb1b3fbd37af0cb8f1467c71a7bdad80429e 100644
--- a/Source/platform/graphics/paint/ClipRecorder.cpp
+++ b/Source/platform/graphics/paint/ClipRecorder.cpp
@@ -12,7 +12,7 @@
namespace blink {
-ClipRecorder::ClipRecorder(GraphicsContext& context, const DisplayItemClientWrapper& client, DisplayItem::Type type, const LayoutRect& clipRect, SkRegion::Op operation)
+ClipRecorder::ClipRecorder(GraphicsContext& context, const DisplayItemClientWrapper& client, DisplayItem::Type type, const LayoutRect& clipRect)
: m_client(client)
, m_context(context)
, m_type(type)
@@ -21,9 +21,9 @@ ClipRecorder::ClipRecorder(GraphicsContext& context, const DisplayItemClientWrap
ASSERT(m_context.displayItemList());
if (m_context.displayItemList()->displayItemConstructionIsDisabled())
return;
- m_context.displayItemList()->add(ClipDisplayItem::create(m_client, type, pixelSnappedIntRect(clipRect), operation));
+ m_context.displayItemList()->createAndAppendIfNeeded<ClipDisplayItem>(m_client, type, pixelSnappedIntRect(clipRect));
} else {
- ClipDisplayItem clipDisplayItem(m_client, type, pixelSnappedIntRect(clipRect), operation);
+ ClipDisplayItem clipDisplayItem(m_client, type, pixelSnappedIntRect(clipRect));
clipDisplayItem.replay(m_context);
}
}
@@ -35,7 +35,7 @@ ClipRecorder::~ClipRecorder()
ASSERT(m_context.displayItemList());
if (m_context.displayItemList()->displayItemConstructionIsDisabled())
return;
- m_context.displayItemList()->add(EndClipDisplayItem::create(m_client, endType));
+ m_context.displayItemList()->createAndAppendIfNeeded<EndClipDisplayItem>(m_client, endType);
} else {
EndClipDisplayItem endClipDisplayItem(m_client, endType);
endClipDisplayItem.replay(m_context);

Powered by Google App Engine
This is Rietveld 408576698