Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Unified Diff: Source/core/paint/FilterPainter.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add ListContainer::AllocateAndConstructWithArguments and a TODO in DisplayItemList::findMatchingIte… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/DisplayItemListPaintTest.cpp ('k') | Source/core/paint/FloatClipRecorder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/FilterPainter.cpp
diff --git a/Source/core/paint/FilterPainter.cpp b/Source/core/paint/FilterPainter.cpp
index a5a8e2457894d0ad241cef5421666626c27155be..19462defc911f61793673cfa0e19a3753b26ed1b 100644
--- a/Source/core/paint/FilterPainter.cpp
+++ b/Source/core/paint/FilterPainter.cpp
@@ -69,14 +69,11 @@ FilterPainter::FilterPainter(DeprecatedPaintLayer& layer, GraphicsContext* conte
// the layer's filter. See crbug.com/502026.
if (webFilterOperations->isEmpty())
return;
- OwnPtr<BeginFilterDisplayItem> filterDisplayItem = BeginFilterDisplayItem::create(*m_layoutObject, imageFilter, rootRelativeBounds, webFilterOperations.release());
-
- context->displayItemList()->add(filterDisplayItem.release());
+ context->displayItemList()->createAndAppend<BeginFilterDisplayItem>(*m_layoutObject, imageFilter, rootRelativeBounds, webFilterOperations.release());
}
} else {
- OwnPtr<BeginFilterDisplayItem> filterDisplayItem = BeginFilterDisplayItem::create(*m_layoutObject, imageFilter, rootRelativeBounds);
-
- filterDisplayItem->replay(*context);
+ BeginFilterDisplayItem filterDisplayItem(*m_layoutObject, imageFilter, rootRelativeBounds);
+ filterDisplayItem.replay(*context);
}
m_filterInProgress = true;
@@ -93,11 +90,11 @@ FilterPainter::~FilterPainter()
if (m_context->displayItemList()->lastDisplayItemIsNoopBegin())
m_context->displayItemList()->removeLastDisplayItem();
else
- m_context->displayItemList()->add(EndFilterDisplayItem::create(*m_layoutObject));
+ m_context->displayItemList()->createAndAppend<EndFilterDisplayItem>(*m_layoutObject);
}
} else {
- OwnPtr<EndFilterDisplayItem> endFilterDisplayItem = EndFilterDisplayItem::create(*m_layoutObject);
- endFilterDisplayItem->replay(*m_context);
+ EndFilterDisplayItem endFilterDisplayItem(*m_layoutObject);
+ endFilterDisplayItem.replay(*m_context);
}
}
« no previous file with comments | « Source/core/paint/DisplayItemListPaintTest.cpp ('k') | Source/core/paint/FloatClipRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698