Source/platform/graphics/paint/DrawingRecorder.cpp - Issue 1193433004: Blink-side contiguous allocation of display items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/paint/DrawingRecorder.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove ListContainer::operatorAt[] Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/paint/DisplayItemList.cpp ('K') | « Source/platform/graphics/paint/DrawingDisplayItem.h ('k') | Source/platform/graphics/paint/FilterDisplayItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/paint/DrawingRecorder.cpp

diff --git a/Source/platform/graphics/paint/DrawingRecorder.cpp b/Source/platform/graphics/paint/DrawingRecorder.cpp

index c697e0b531344892b760bb0fd1407bbd410f18af..f4288f6ebed779388ebfe45e99d8b76ce46d1a12 100644

--- a/Source/platform/graphics/paint/DrawingRecorder.cpp

+++ b/Source/platform/graphics/paint/DrawingRecorder.cpp

@@ -91,16 +91,15 @@ DrawingRecorder::~DrawingRecorder()

m_displayItemClient.debugName().utf8().data());

}

#endif

- m_context.displayItemList()->add(CachedDisplayItem::create(m_displayItemClient, DisplayItem::drawingTypeToCachedType(m_displayItemType)));

+ m_context.displayItemList()->createAndAppend<CachedDisplayItem>(m_displayItemClient, DisplayItem::drawingTypeToCachedType(m_displayItemType));

} else {

- OwnPtr<DrawingDisplayItem> drawingDisplayItem = DrawingDisplayItem::create(m_displayItemClient

+ m_context.displayItemList()->createAndAppend<DrawingDisplayItem>(m_displayItemClient

, m_displayItemType

, m_context.endRecording()

#if ENABLE(ASSERT)

, m_underInvalidationCheckingMode

#endif

);

- m_context.displayItemList()->add(drawingDisplayItem.release());

}