Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Unified Diff: Source/core/paint/FloatClipRecorder.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Minor tweaks to make reviewing easier Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/FloatClipRecorder.cpp
diff --git a/Source/core/paint/FloatClipRecorder.cpp b/Source/core/paint/FloatClipRecorder.cpp
index afb14eaed42c5e9b2a5117535664de57a8be280c..228de5336020b2be2ae197783a5e9c91bbd28a52 100644
--- a/Source/core/paint/FloatClipRecorder.cpp
+++ b/Source/core/paint/FloatClipRecorder.cpp
@@ -21,10 +21,10 @@ FloatClipRecorder::FloatClipRecorder(GraphicsContext& context, const DisplayItem
ASSERT(m_context.displayItemList());
if (m_context.displayItemList()->displayItemConstructionIsDisabled())
return;
- m_context.displayItemList()->add(FloatClipDisplayItem::create(m_client, m_clipType, clipRect));
+ m_context.displayItemList()->createAndAppend<FloatClipDisplayItem>(m_client, m_clipType, clipRect);
} else {
- FloatClipDisplayItem clipDisplayItem(m_client, m_clipType, clipRect);
- clipDisplayItem.replay(m_context);
+ FloatClipDisplayItem floatClipDisplayItem(m_client, m_clipType, clipRect);
+ floatClipDisplayItem.replay(m_context);
}
}
@@ -37,11 +37,11 @@ FloatClipRecorder::~FloatClipRecorder()
if (m_context.displayItemList()->lastDisplayItemIsNoopBegin())
m_context.displayItemList()->removeLastDisplayItem();
else
- m_context.displayItemList()->add(EndFloatClipDisplayItem::create(m_client, endType));
+ m_context.displayItemList()->createAndAppend<EndFloatClipDisplayItem>(m_client, endType);
}
} else {
- EndFloatClipDisplayItem endClipDisplayItem(m_client, endType);
- endClipDisplayItem.replay(m_context);
+ EndFloatClipDisplayItem floatClipDisplayItem(m_client, endType);
jbroman 2015/06/29 18:11:56 Why this variable name change? The old name seems
pdr. 2015/06/29 22:20:03 Reverted back to the original name.
+ floatClipDisplayItem.replay(m_context);
}
}

Powered by Google App Engine
This is Rietveld 408576698