Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/paint/ScrollRecorder.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add ListContainer::AllocateAndConstructWithArguments and a TODO in DisplayItemList::findMatchingIte… Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/paint/SVGMaskPainter.cpp ('k') | Source/core/paint/SubtreeRecorder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/paint/ScrollRecorder.h" 6 #include "core/paint/ScrollRecorder.h"
7 7
8 #include "platform/RuntimeEnabledFeatures.h" 8 #include "platform/RuntimeEnabledFeatures.h"
9 #include "platform/graphics/GraphicsContext.h" 9 #include "platform/graphics/GraphicsContext.h"
10 #include "platform/graphics/paint/DisplayItemList.h" 10 #include "platform/graphics/paint/DisplayItemList.h"
11 #include "platform/graphics/paint/ScrollDisplayItem.h" 11 #include "platform/graphics/paint/ScrollDisplayItem.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 ScrollRecorder::ScrollRecorder(GraphicsContext& context, const DisplayItemClient Wrapper& client, PaintPhase phase, const IntSize& currentOffset) 15 ScrollRecorder::ScrollRecorder(GraphicsContext& context, const DisplayItemClient Wrapper& client, PaintPhase phase, const IntSize& currentOffset)
16 : m_client(client) 16 : m_client(client)
17 , m_beginItemType(DisplayItem::paintPhaseToScrollType(phase)) 17 , m_beginItemType(DisplayItem::paintPhaseToScrollType(phase))
18 , m_context(context) 18 , m_context(context)
19 { 19 {
20 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) { 20 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
21 ASSERT(m_context.displayItemList()); 21 ASSERT(m_context.displayItemList());
22 if (m_context.displayItemList()->displayItemConstructionIsDisabled()) 22 if (m_context.displayItemList()->displayItemConstructionIsDisabled())
23 return; 23 return;
24 m_context.displayItemList()->add(BeginScrollDisplayItem::create(m_client , m_beginItemType, currentOffset)); 24 m_context.displayItemList()->createAndAppend<BeginScrollDisplayItem>(m_c lient, m_beginItemType, currentOffset);
25 } else { 25 } else {
26 BeginScrollDisplayItem scrollDisplayItem(m_client, m_beginItemType, curr entOffset); 26 BeginScrollDisplayItem scrollDisplayItem(m_client, m_beginItemType, curr entOffset);
27 scrollDisplayItem.replay(m_context); 27 scrollDisplayItem.replay(m_context);
28 } 28 }
29 } 29 }
30 30
31 ScrollRecorder::~ScrollRecorder() 31 ScrollRecorder::~ScrollRecorder()
32 { 32 {
33 DisplayItem::Type endItemType = DisplayItem::scrollTypeToEndScrollType(m_beg inItemType); 33 DisplayItem::Type endItemType = DisplayItem::scrollTypeToEndScrollType(m_beg inItemType);
34 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) { 34 if (RuntimeEnabledFeatures::slimmingPaintEnabled()) {
35 ASSERT(m_context.displayItemList()); 35 ASSERT(m_context.displayItemList());
36 if (!m_context.displayItemList()->displayItemConstructionIsDisabled()) { 36 if (!m_context.displayItemList()->displayItemConstructionIsDisabled()) {
37 if (m_context.displayItemList()->lastDisplayItemIsNoopBegin()) 37 if (m_context.displayItemList()->lastDisplayItemIsNoopBegin())
38 m_context.displayItemList()->removeLastDisplayItem(); 38 m_context.displayItemList()->removeLastDisplayItem();
39 else 39 else
40 m_context.displayItemList()->add(EndScrollDisplayItem::create(m_ client, endItemType)); 40 m_context.displayItemList()->createAndAppend<EndScrollDisplayIte m>(m_client, endItemType);
41 } 41 }
42 } else { 42 } else {
43 EndScrollDisplayItem endScrollDisplayItem(m_client, endItemType); 43 EndScrollDisplayItem endScrollDisplayItem(m_client, endItemType);
44 endScrollDisplayItem.replay(m_context); 44 endScrollDisplayItem.replay(m_context);
45 } 45 }
46 } 46 }
47 47
48 } // namespace blink 48 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/paint/SVGMaskPainter.cpp ('k') | Source/core/paint/SubtreeRecorder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698