Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: Source/core/layout/LayoutTable.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Minor tweaks to make reviewing easier Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1292 matching lines...) Expand 10 before | Expand all | Expand 10 after
1303 return topNonEmptySection->logicalTop() + baseline; 1303 return topNonEmptySection->logicalTop() + baseline;
1304 1304
1305 // FF, Presto and IE use the top of the section as the baseline if its first row is empty of cells or content. 1305 // FF, Presto and IE use the top of the section as the baseline if its first row is empty of cells or content.
1306 // The baseline of an empty row isn't specified by CSS 2.1. 1306 // The baseline of an empty row isn't specified by CSS 2.1.
1307 if (topNonEmptySection->firstRow() && !topNonEmptySection->firstRow()->first Cell()) 1307 if (topNonEmptySection->firstRow() && !topNonEmptySection->firstRow()->first Cell())
1308 return topNonEmptySection->logicalTop(); 1308 return topNonEmptySection->logicalTop();
1309 1309
1310 return -1; 1310 return -1;
1311 } 1311 }
1312 1312
1313 LayoutRect LayoutTable::overflowClipRect(const LayoutPoint& location, OverlayScr ollbarSizeRelevancy relevancy) 1313 LayoutRect LayoutTable::overflowClipRect(const LayoutPoint& location, OverlayScr ollbarSizeRelevancy relevancy) const
1314 { 1314 {
1315 LayoutRect rect = LayoutBlock::overflowClipRect(location, relevancy); 1315 LayoutRect rect = LayoutBlock::overflowClipRect(location, relevancy);
1316 1316
1317 // If we have a caption, expand the clip to include the caption. 1317 // If we have a caption, expand the clip to include the caption.
1318 // FIXME: Technically this is wrong, but it's virtually impossible to fix th is 1318 // FIXME: Technically this is wrong, but it's virtually impossible to fix th is
1319 // for real until captions have been re-written. 1319 // for real until captions have been re-written.
1320 // FIXME: This code assumes (like all our other caption code) that only top/ bottom are 1320 // FIXME: This code assumes (like all our other caption code) that only top/ bottom are
1321 // supported. When we actually support left/right and stop mapping them to top/bottom, 1321 // supported. When we actually support left/right and stop mapping them to top/bottom,
1322 // we might have to hack this code first (depending on what order we do thes e bug fixes in). 1322 // we might have to hack this code first (depending on what order we do thes e bug fixes in).
1323 if (!m_captions.isEmpty()) { 1323 if (!m_captions.isEmpty()) {
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
1416 cell->invalidateDisplayItemClient(*cell); 1416 cell->invalidateDisplayItemClient(*cell);
1417 } 1417 }
1418 } 1418 }
1419 } 1419 }
1420 } 1420 }
1421 1421
1422 LayoutBlock::invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState); 1422 LayoutBlock::invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState);
1423 } 1423 }
1424 1424
1425 } 1425 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698