Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1193433003: Add signcla verifier to skia (Closed)

Created:
5 years, 6 months ago by sheyang
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add signcla verifier to skia. This verifier is just informative now. BUG=457428 Committed: https://skia.googlesource.com/skia/+/12555d7efbd1e2238e7e7a7eee6b651f304ba451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M infra/branch-config/cq.cfg View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
sheyang
5 years, 6 months ago (2015-06-16 18:50:13 UTC) #2
Sergiy Byelozyorov
lgtm
5 years, 6 months ago (2015-06-16 20:12:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193433003/1
5 years, 6 months ago (2015-06-16 20:48:27 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 6 months ago (2015-06-16 20:48:29 UTC) #6
rmistry
Added Heather as a required reviewer.
5 years, 6 months ago (2015-06-16 20:51:29 UTC) #9
hcm
On 2015/06/16 20:51:29, rmistry wrote: > Added Heather as a required reviewer. I think we're ...
5 years, 6 months ago (2015-06-17 01:58:42 UTC) #10
sheyang
On 2015/06/17 01:58:42, hcm wrote: > On 2015/06/16 20:51:29, rmistry wrote: > > Added Heather ...
5 years, 6 months ago (2015-06-17 01:59:55 UTC) #11
hcm
On 2015/06/17 01:59:55, sheyang wrote: > On 2015/06/17 01:58:42, hcm wrote: > > On 2015/06/16 ...
5 years, 6 months ago (2015-06-17 02:44:52 UTC) #12
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 6 months ago (2015-06-17 02:48:08 UTC) #14
rmistry
On 2015/06/17 02:48:08, commit-bot: I haz the power wrote: > All required reviewers (with asterisk ...
5 years, 6 months ago (2015-06-17 10:47:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193433003/1
5 years, 6 months ago (2015-06-17 16:15:13 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 16:15:56 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/12555d7efbd1e2238e7e7a7eee6b651f304ba451

Powered by Google App Engine
This is Rietveld 408576698