|
|
DescriptionAdd signcla verifier to skia.
This verifier is just informative now.
BUG=457428
Committed: https://skia.googlesource.com/skia/+/12555d7efbd1e2238e7e7a7eee6b651f304ba451
Patch Set 1 #
Messages
Total messages: 19 (7 generated)
sheyang@chromium.org changed reviewers: + hcm@chromium.org, rmistry@chromium.org, sergiyb@chromium.org
lgtm
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193433003/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-06-17 02:48 UTC
rmistry@google.com changed required reviewers: + hcm@chromium.org
rmistry@google.com changed reviewers: + rmistry@google.com
Added Heather as a required reviewer.
On 2015/06/16 20:51:29, rmistry wrote: > Added Heather as a required reviewer. I think we're good, but was trying to find it in some of the other CLs on this work- what is the message we'll see as a result of the check?
On 2015/06/17 01:58:42, hcm wrote: > On 2015/06/16 20:51:29, rmistry wrote: > > Added Heather as a required reviewer. > > I think we're good, but was trying to find it in some of the other CLs on this > work- what is the message we'll see as a result of the check? "The author johndoe@chromium.org has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA."
On 2015/06/17 01:59:55, sheyang wrote: > On 2015/06/17 01:58:42, hcm wrote: > > On 2015/06/16 20:51:29, rmistry wrote: > > > Added Heather as a required reviewer. > > > > I think we're good, but was trying to find it in some of the other CLs on this > > work- what is the message we'll see as a result of the check? > > "The author mailto:johndoe@chromium.org has not signed Google Contributor License > Agreement. Please visit https://cla.developers.google.com to sign and manage > CLA." thanks, lgtm
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from a valid reviewer yet. Please ask for an LGTM from a full Skia committer from https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS
rmistry@google.com changed required reviewers: - hcm@chromium.org
On 2015/06/17 02:48:08, commit-bot: I haz the power wrote: > All required reviewers (with asterisk prefixes) have not yet approved this CL. > > No LGTM from a valid reviewer yet. Please ask for an LGTM from a > full Skia committer from > https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS LGTM Failed because I had marked Heather's other account as a required reviewer. I removed it. Sheng, this should be good to go now.
The CQ bit was checked by sheyang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193433003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/12555d7efbd1e2238e7e7a7eee6b651f304ba451 |