Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1193433002: MIPS: Fix unaligned memory access. (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix unaligned memory access. On MIPS32 we can't read a 8 bytes long data from a not 8 bytes aligned memory address. BUG= TEST=mjsunit/debug-backtrace Committed: https://crrev.com/0acc511e62fbd717e335c700012de47827fe0630 Cr-Commit-Position: refs/heads/master@{#29100}

Patch Set 1 #

Patch Set 2 : Moved to utils.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M src/deoptimizer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 1 chunk +4 lines, -39 lines 0 comments Download
M src/utils.h View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
This does need a v8-team review. PTAL if alignment fix is acceptable in v8 this ...
5 years, 6 months ago (2015-06-17 16:10:46 UTC) #2
paul.l...
lgtm
5 years, 6 months ago (2015-06-17 16:14:17 UTC) #3
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-18 06:14:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193433002/20001
5 years, 6 months ago (2015-06-18 06:14:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-18 07:01:29 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 07:01:49 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0acc511e62fbd717e335c700012de47827fe0630
Cr-Commit-Position: refs/heads/master@{#29100}

Powered by Google App Engine
This is Rietveld 408576698